Feat: Allow raising errors from within a custom whatever(#2718) #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abdalla-rko If the goal is to update the |
|
@abdalla-rko are you still working on this? |
|
Hi @heath-freenome, Sorry for taking too long. I think the initial implementation is now like you suggested updating the errorSchema using onChange in the custom widget. Let me know if it's good and then I'll update the docs and other themes if needed. |
heath-freenome
requested changes
Jul 19, 2024
packages/docs/docs/advanced-customization/custom-widgets-fields.md
Outdated
Show resolved
Hide resolved
packages/docs/docs/advanced-customization/custom-widgets-fields.md
Outdated
Show resolved
Hide resolved
Ordered lodash import
Added missing packages
Added missing space
heath-freenome
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
I introduced a raiseFieldErrors method to raise errors from within a custom component(see #2718).
The current behavior allows errors to be raised from custom components and when the form onChange is triggered, we clear the custom raised errors. I appreciate any feedback on this approach. If everything looks good, I'll write tests and implement this in other themes.
Checklist
npm run test:updateto update snapshots, if needed.